Fetch all and sort menu sets #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 14, 2016 12:42
Allows devs to fetch all created MenuSets, or optionally fetch all and ".Limit()"
wilr
pushed a commit
that referenced
this pull request
Oct 5, 2022
|
Handy! Needed this for a new project as well so rebased and merged feature in 29f8134. Thanks @chrispenny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find it useful to loop through all
MenuSets that have been created instead of having to hard codeMenuSetnames into our templates. This is most often the case when we're using the Menu Manager to control a single area of the website. EG: A footer with 4MenuSets (Limit(4)), or a vertical side nav where we don't mind how manyMenuSets the admin creates.Consequently, if we're looping through
MenuSets systematically then it's also useful to allow admins to change the sort order of those sets.I'm currently achieving this by adding a method to my
SiteConfigto get allMenuSets (with or without aLimit()), but I thought that others might also find this option useful.Future improvements: Increase visibility in the CMS as to how many
Set/Items are being displayed on the frontend (if they are being limited). So far though, I've found it easy enough to just tell the admins "only the top [number] will show in [area]".